feat: Allow users to add multiple Applications to entities #15160

ani-malgari · 2025-10-30T21:25:49Z

Previously, it was designed to only allow 1 application per asset. This PR allows setting multiple applications per asset. The changes include:

ApplicationService.java

Modified batchSetApplicationAssets to append applications rather than replace existing ones
Added batchUnsetApplicationAssets to remove application for assets.

ApplicationAssociationMapper.java

Added mapList() method to return a list of ApplicationAssociation objects
Kept the legacy map() method for backward compatibility

SidebarApplicationSection

The component now displays all applications associated with an entity
Updated removeApplication function to use useBatchUnsetApplicationMutation hook

Adding applications:
https://github.com/user-attachments/assets/3a00e706-f35f-4e56-a4d1-0dab3dd2041c

Removing applications:
https://github.com/user-attachments/assets/406efa6a-5a8a-4b16-a382-888dec4b3015

alwaysmeticulous · 2025-10-30T21:31:59Z

🔴 Meticulous spotted visual differences in 331 of 1134 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

_{Last updated for commit 663211b. This comment will update as new commits are pushed.}

codecov · 2025-10-30T21:33:07Z

Bundle Report

Changes will increase total bundle size by 10.58kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	28.63MB	10.58kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	10.58kB	19.0MB	0.06%

Files in assets/index-*.js:

./src/app/entityV2/shared/containers/profile/sidebar/Applications/SidebarApplicationSection.tsx → Total Size: 3.52kB
./src/app/domainV2/CreateDomainModal.tsx → Total Size: 6.01kB
./src/app/domain/utils.ts → Total Size: 3.01kB
./src/app/domain/DomainsList.tsx → Total Size: 5.74kB
./src/app/entity/shared/types.ts → Total Size: 153 bytes
./src/app/domain/CreateDomainModal.tsx → Total Size: 6.25kB

codecov · 2025-10-30T21:55:28Z

Codecov Report

❌ Patch coverage is 44.01709% with 131 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...com/linkedin/datahub/graphql/GmsGraphQLEngine.java	0.00%	97 Missing ⚠️
...ypes/application/ApplicationAssociationMapper.java	35.71%	8 Missing and 1 partial ⚠️
.../linkedin/metadata/service/ApplicationService.java	91.83%	2 Missing and 2 partials ⚠️
...tahub/graphql/types/chart/mappers/ChartMapper.java	0.00%	2 Missing ⚠️
...aphql/types/dashboard/mappers/DashboardMapper.java	0.00%	2 Missing ⚠️
...graphql/types/dataflow/mappers/DataFlowMapper.java	0.00%	2 Missing ⚠️
...b/graphql/types/datajob/mappers/DataJobMapper.java	0.00%	2 Missing ⚠️
...b/graphql/types/dataset/mappers/DatasetMapper.java	0.00%	2 Missing ⚠️
...hql/types/glossary/mappers/GlossaryTermMapper.java	0.00%	2 Missing ⚠️
...graphql/types/mlmodel/mappers/MLFeatureMapper.java	0.00%	2 Missing ⚠️
... and 4 more

❌ Your patch check has failed because the patch coverage (44.01%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

gabe-lyons · 2025-10-30T23:09:21Z

datahub-web-react/src/graphql/chart.graphql

            ...entityDomain
        }
-        application {
+        applications {


so, this constitutes a minor, but still real, breaking change. lets make sure we include this in the next version release notes

...rc/app/entityV2/shared/containers/profile/sidebar/Applications/SidebarApplicationSection.tsx

...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java

…ns-on-entities

chriscollins3456

nice! this is great stuff all around. i only have one main comment around making a backwards incompatible change to our graphql api.

shouldn't be a huge change then i think this is probably good to go

chriscollins3456 · 2025-11-06T14:43:23Z

datahub-graphql-core/src/main/resources/entity.graphql

-  The application associated with the dataset
+  The applications associated with the dataset
  """
-  application: ApplicationAssociation


so this is technically a backwards incompatible change to remove a field from graphql like this. since all of our API changes need to be backwards compatible I think we will need to instead mark this field as deprecated and then create a new applications field like you have here

same thing everywhere below

makes sense! i debated because i made the intended UI changes but API needs to be backwards compatible nevertheless

lmk what you think of the updates now

ani-malgari · 2025-11-06T21:18:37Z

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java

                              : null;
-                        })));
+                        }))
+                .dataFetcher(


@chriscollins3456 - ptal of the resolver changes here to support application. i made updates here instead of making changes to all the mappers to support setApplication.

Anirudh Reddy Malgari added 2 commits October 29, 2025 17:50

Able to add multiple apps, need to work on removal

ec6e451

need tests

70109d1

github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 30, 2025

github-actions bot deployed to datahub-project-web-react (Preview) October 30, 2025 21:31 View deployment

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 30, 2025

vercel bot deployed to Preview October 30, 2025 21:41 View deployment

Added tests

f6312d3

github-actions bot deployed to datahub-project-web-react (Preview) October 30, 2025 22:05 View deployment

ani-malgari changed the title ~~WIP: Updates to Applications~~ Allow multiple Applications Oct 30, 2025

ani-malgari changed the title ~~Allow multiple Applications~~ feat: Allow users to add multiple Applications to entities Oct 30, 2025

vercel bot deployed to Preview October 30, 2025 22:17 View deployment

fix formatting

88013a6

github-actions bot deployed to datahub-project-web-react (Preview) October 30, 2025 22:34 View deployment

ani-malgari requested review from asikowitz, benjiaming and chriscollins3456 October 30, 2025 22:38

vercel bot deployed to Preview October 30, 2025 22:46 View deployment

gabe-lyons reviewed Oct 30, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 30, 2025

gabe-lyons reviewed Oct 30, 2025

View reviewed changes

...rc/app/entityV2/shared/containers/profile/sidebar/Applications/SidebarApplicationSection.tsx Outdated Show resolved Hide resolved

gabe-lyons reviewed Oct 30, 2025

View reviewed changes

...hql-core/src/main/java/com/linkedin/datahub/graphql/types/dataset/mappers/DatasetMapper.java Show resolved Hide resolved

minor changes

392617b

github-actions bot deployed to datahub-project-web-react (Preview) October 31, 2025 22:58 View deployment

datahub-cyborg bot removed the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Oct 31, 2025

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 31, 2025

vercel bot deployed to Preview October 31, 2025 23:10 View deployment

updated schema in mocks

941ebe6

github-actions bot deployed to datahub-project-web-react (Preview) November 5, 2025 01:25 View deployment

vercel bot deployed to Preview November 5, 2025 01:38 View deployment

Merge branch 'master' into feature/cus-6090_allow-multiple-applicatio…

53c201a

…ns-on-entities

github-actions bot deployed to datahub-project-web-react (Preview) November 5, 2025 21:39 View deployment

vercel bot deployed to Preview November 5, 2025 21:51 View deployment

Anirudh Reddy Malgari added 2 commits November 5, 2025 16:24

fixing cypress tests

1ee6fbb

fix v1 UI

02e6637

github-actions bot deployed to datahub-project-web-react (Preview) November 6, 2025 01:00 View deployment

vercel bot deployed to Preview November 6, 2025 01:13 View deployment

improved test coverage

8d619c1

github-actions bot deployed to datahub-project-web-react (Preview) November 6, 2025 01:46 View deployment

vercel bot deployed to Preview November 6, 2025 01:59 View deployment

chriscollins3456 reviewed Nov 6, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 6, 2025

allow application for backward compatibility

1f9c0a6

ani-malgari commented Nov 6, 2025

View reviewed changes

github-actions bot deployed to datahub-project-web-react (Preview) November 6, 2025 21:18 View deployment

datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 6, 2025

vercel bot deployed to Preview November 6, 2025 21:30 View deployment

prettier

33cd334

github-actions bot deployed to datahub-project-web-react (Preview) November 6, 2025 22:12 View deployment

vercel bot deployed to Preview November 6, 2025 22:26 View deployment

fixed spotless java check

663211b

github-actions bot deployed to datahub-project-web-react (Preview) November 6, 2025 22:44 View deployment

vercel bot deployed to Preview November 6, 2025 23:23 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Allow users to add multiple Applications to entities #15160

feat: Allow users to add multiple Applications to entities #15160

ani-malgari commented Oct 30, 2025 •

edited

Loading

Uh oh!

alwaysmeticulous bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Assets Changed:

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

gabe-lyons Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

chriscollins3456 left a comment

Uh oh!

chriscollins3456 Nov 6, 2025

Uh oh!

chriscollins3456 Nov 6, 2025

Uh oh!

ani-malgari Nov 6, 2025

Uh oh!

ani-malgari Nov 6, 2025

Uh oh!

ani-malgari Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Allow users to add multiple Applications to entities #15160

Are you sure you want to change the base?

feat: Allow users to add multiple Applications to entities #15160

Conversation

ani-malgari commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alwaysmeticulous bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gabe-lyons Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

ani-malgari Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

ani-malgari Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

ani-malgari Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ani-malgari commented Oct 30, 2025 •

edited

Loading

alwaysmeticulous bot commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading